Skip to content

fix(type-merging): handle union types correctly#4920

Merged
ardatan merged 1 commit intomasterfrom
union-tm
Dec 21, 2022
Merged

fix(type-merging): handle union types correctly#4920
ardatan merged 1 commit intomasterfrom
union-tm

Conversation

@ardatan
Copy link
Copy Markdown
Owner

@ardatan ardatan commented Dec 21, 2022

Fixes #4902

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Dec 21, 2022

🦋 Changeset detected

Latest commit: e0e9bbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@graphql-tools/delegate Patch
@graphql-tools/batch-delegate Patch
@graphql-tools/links Patch
@graphql-tools/stitch Patch
@graphql-tools/stitching-directives Patch
@graphql-tools/wrap Patch
@graphql-tools/url-loader Patch
federation-benchmark Patch
@graphql-tools/prisma-loader Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ardatan ardatan mentioned this pull request Dec 21, 2022
Closed
4 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 21, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/batch-delegate 8.4.14-alpha-20221221151250-ecb6851f npm ↗︎ unpkg ↗︎
@graphql-tools/delegate 9.0.21-alpha-20221221151250-ecb6851f npm ↗︎ unpkg ↗︎
@graphql-tools/links 8.3.25-alpha-20221221151250-ecb6851f npm ↗︎ unpkg ↗︎
@graphql-tools/prisma-loader 7.2.48-alpha-20221221151250-ecb6851f npm ↗︎ unpkg ↗︎
@graphql-tools/url-loader 7.16.28-alpha-20221221151250-ecb6851f npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 8.7.34-alpha-20221221151250-ecb6851f npm ↗︎ unpkg ↗︎
@graphql-tools/stitching-directives 2.3.24-alpha-20221221151250-ecb6851f npm ↗︎ unpkg ↗︎
@graphql-tools/wrap 9.2.23-alpha-20221221151250-ecb6851f npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 21, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 176      ✗ 0  
     data_received..................: 21 MB   2.0 MB/s
     data_sent......................: 75 kB   7.5 kB/s
     http_req_blocked...............: avg=7.31µs   min=3.3µs    med=4.3µs    max=241.71µs p(90)=5.4µs    p(95)=5.79µs  
     http_req_connecting............: avg=1.85µs   min=0s       med=0s       max=162.91µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=106.92ms min=88.1ms   med=100.81ms max=249.79ms p(90)=125.2ms  p(95)=163.96ms
       { expected_response:true }...: avg=106.92ms min=88.1ms   med=100.81ms max=249.79ms p(90)=125.2ms  p(95)=163.96ms
     http_req_failed................: 0.00%   ✓ 0        ✗ 88 
     http_req_receiving.............: avg=245.75µs min=154.71µs med=185.61µs max=1.5ms    p(90)=336.06µs p(95)=375.87µs
     http_req_sending...............: avg=96.32µs  min=23.7µs   med=32.4µs   max=1.81ms   p(90)=48.72µs  p(95)=306.52µs
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=106.58ms min=87.89ms  med=100.55ms max=248.21ms p(90)=124.1ms  p(95)=163.71ms
     http_reqs......................: 88      8.746077/s
     iteration_duration.............: avg=114.29ms min=94.33ms  med=107.47ms max=256.62ms p(90)=132.37ms p(95)=171.09ms
     iterations.....................: 88      8.746077/s
     vus............................: 1       min=1      max=1
     vus_max........................: 1       min=1      max=1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 21, 2022

🚀 Website Preview

The latest changes to the website are available as preview in: https://cf5e691d.graphql-tools.pages.dev

@ardatan ardatan merged commit 1317779 into master Dec 21, 2022
@ardatan ardatan deleted the union-tm branch December 21, 2022 15:18
@github-actions github-actions bot mentioned this pull request Dec 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stitched graph with federationToStitchingSDL fails to resolve a computed field

1 participant

@ardatan
⚡